Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This is a very bad bug that snuck in after #15007. Essentially, it didn't come up during testing because of a bug in my testing script. The
Service#run
handles strings by turning them into arrays. The string argument gets turned into an array internally but we skip that to preserve all args in the@run_params
variable. That means that we have to handle strings when deserializing too.This affects 58 services by my count and makes the services impossible to install correctly since the path deserialization doesn't work at all.
I've updated the testing script from before to not skip services without commands which was something I did early on because of one false positive. I also added some more testing around the different run command parameter types.